-
Notifications
You must be signed in to change notification settings - Fork 19
Add support for autodetection of gres resources #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some concerns
Ready for review but merge #183 first (this PR targets that branch to avoid noise in diff) |
e3f58ad
to
1ca4a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, but looks pretty good to me.
4ed9a81
to
e8c09aa
Compare
e8c09aa
to
facef75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Adds support for setting the AutoDetection property on gres resources. This prevents the need to manually specify File in the gres dictionary. You can only use one auto-detection mechanism per node, otherwise slurm will complain - hence why it is a per-nodegroup option and not a per-gres option.
Example:
NB: autodetection requires rebuild of the OpenHPC packages - this is not provided by this role